netdev - Re: [PATCH ethtool 3/7] ioctl: get rid of signed/unsigned comparison warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200810141924.GF2123435@lunn.ch>
Date:   Mon, 10 Aug 2020 16:19:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 3/7] ioctl: get rid of signed/unsigned comparison
 warnings

> -	while (arg_num < ctx->argc) {
> +	while (arg_num < (unsigned int)ctx->argc) {

Did you try changing ctx->argc to an unsigned int? I guess there would
be less casts that way, and it is a more logical type for this.

    Andrew