netdev - Re: [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87imdo1ajl.fsf@toke.dk>
Date:   Wed, 12 Aug 2020 11:24:46 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>,
        Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST

Andrii Nakryiko <andriin@...com> writes:

> Enforce XDP_FLAGS_UPDATE_IF_NOEXIST only if new BPF program to be attached is
> non-NULL (i.e., we are not detaching a BPF program).
>
> Reported-by: Stanislav Fomichev <sdf@...gle.com>
> Fixes: d4baa9368a5e ("bpf, xdp: Extract common XDP program attachment logic")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>