netdev - Re: [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Aug 2020 08:47:06 -0700
From:   Stanislav Fomichev <sdf@...gle.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST

On Wed, Aug 12, 2020 at 2:24 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Andrii Nakryiko <andriin@...com> writes:
>
> > Enforce XDP_FLAGS_UPDATE_IF_NOEXIST only if new BPF program to be attached is
> > non-NULL (i.e., we are not detaching a BPF program).
> >
> > Reported-by: Stanislav Fomichev <sdf@...gle.com>
> > Fixes: d4baa9368a5e ("bpf, xdp: Extract common XDP program attachment logic")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>
That fixed it for me, thank you!

Tested-by: Stanislav Fomichev <sdf@...gle.com>