netdev - Re: [PATCH ethtool v2] Add QSFP-DD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_jBfTUpcooEMdcaj1QsvGkD2AP_w+WzyZAzTr9nR4_6FNzHQ@mail.gmail.com>
Date:   Thu, 13 Aug 2020 10:23:17 +0300
From:   Adrian Pop <popadrian1996@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, vadimp@...lanox.com, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Paul Schmidt <paschmidt@...dia.com>
Subject: Re: [PATCH ethtool v2] Add QSFP-DD support

Hi Andrew!

I removed all the comments/constants/structs/functions that were
assuming the existence of page 0x10 and 0x11. I sent v3 to Ido (before
submitting it), he helped me test it and everything works fine. Please
let me know if there's anything else that should be changed.

Also, I just noticed I forgot to sign-off the patch. Can the following
lines be added by you or it's me who needs to add them by
re-submitting?
Signed-off-by: Adrian Pop <popadrian1996@...il.com>
Tested-by: Ido Schimmel <idosch@...lanox.com>

Thank you!
Adrian

On Sat, 8 Aug 2020 at 17:30, Andrew Lunn <andrew@...n.ch> wrote:
>
> On Thu, Aug 06, 2020 at 07:21:21PM +0300, Adrian Pop wrote:
> > Hi Andrew!
> >
> > Should I resubmit v3 after I delete the code that has to do with page
> > 0x10 and 0x11?
>
> Yes please.
>
>     Andrew