netdev - Re: [PATCH ethtool v3] Add QSFP-DD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200813092402.GA3426088@shredder>
Date:   Thu, 13 Aug 2020 12:24:02 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Adrian Pop <popadrian1996@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, vadimp@...lanox.com, andrew@...n.ch,
        mlxsw@...lanox.com, idosch@...lanox.com, roopa@...dia.com,
        paschmidt@...dia.com
Subject: Re: [PATCH ethtool v3] Add QSFP-DD support

On Thu, Aug 13, 2020 at 10:17:35AM +0300, Adrian Pop wrote:
> The Common Management Interface Specification (CMIS) for QSFP-DD shares
> some similarities with other form factors such as QSFP or SFP, but due to
> the fact that the module memory map is different, the current ethtool
> version is not able to provide relevant information about an interface.
> 
> This patch adds QSFP-DD support to ethtool. The changes are similar to
> the ones already existing in qsfp.c, but customized to use the memory
> addresses and logic as defined in the specifications document.
> 
> Several functions from qsfp.c could be reused, so an additional parameter
> was added to each and the functions were moved to sff-common.c.
> 
> Changelog (diff from v2):
> * Remove functions assuming the existance of page 0x10 and 0x11
> * Remove structs and constants related to the page 0x10 and 0x11

Adrian, you're missing diff from v1 and Signed-off-by tag.

Please send v4 with these changes.

And please CC Michal Kubecek <mkubecek@...e.cz> on ethtool patches since
he maintains the tool.

Thanks

> ---