netdev - Re: [PATCH ethtool v3] Add QSFP-DD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Aug 2020 10:38:38 +0300
From:   Adrian Pop <popadrian1996@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, vadimp@...lanox.com,
        Andrew Lunn <andrew@...n.ch>, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Paul Schmidt <paschmidt@...dia.com>
Subject: Re: [PATCH ethtool v3] Add QSFP-DD support

Hi!

Sorry for that. I'll resubmit v4 and I'll add diff from v1, diff from
v2 and diff from v3.
I will also add Michal Kubecek.

Adrian

On Thu, 13 Aug 2020 at 12:24, Ido Schimmel <idosch@...sch.org> wrote:
>
> On Thu, Aug 13, 2020 at 10:17:35AM +0300, Adrian Pop wrote:
> > The Common Management Interface Specification (CMIS) for QSFP-DD shares
> > some similarities with other form factors such as QSFP or SFP, but due to
> > the fact that the module memory map is different, the current ethtool
> > version is not able to provide relevant information about an interface.
> >
> > This patch adds QSFP-DD support to ethtool. The changes are similar to
> > the ones already existing in qsfp.c, but customized to use the memory
> > addresses and logic as defined in the specifications document.
> >
> > Several functions from qsfp.c could be reused, so an additional parameter
> > was added to each and the functions were moved to sff-common.c.
> >
> > Changelog (diff from v2):
> > * Remove functions assuming the existance of page 0x10 and 0x11
> > * Remove structs and constants related to the page 0x10 and 0x11
>
> Adrian, you're missing diff from v1 and Signed-off-by tag.
>
> Please send v4 with these changes.
>
> And please CC Michal Kubecek <mkubecek@...e.cz> on ethtool patches since
> he maintains the tool.
>
> Thanks
>
> > ---