netdev - Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f6ec0c0d37f54298956a63ebe1ebf234@huawei.com>
Date:   Sat, 15 Aug 2020 01:48:18 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>>
>> Convert the uses of fallthrough comments to fallthrough macro.
>> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int size,
>>                         return prog->expected_attach_type ==
>>                                 BPF_CGROUP_GETSOCKOPT;
>>                 case offsetof(struct bpf_sockopt, optname):
>> -                       /* fallthrough */
>> +                       fallthrough;
>
>this fallthrough is not event necessary, let's drop it instead?

Will do. Many thanks.

>
>>                 case offsetof(struct bpf_sockopt, level):
>>                         if (size != size_default)
>>                                 return false;
>
> [...]