netdev - Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <878cef61a8c549fd92764314e7c07a95@huawei.com>
Date:   Sat, 15 Aug 2020 01:50:20 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Yonghong Song <yhs@...com>
CC:     "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "kafai@...com" <kafai@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "andriin@...com" <andriin@...com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kpsingh@...omium.org" <kpsingh@...omium.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

Yonghong Song <yhs@...com> wrote:
>On 8/14/20 2:16 AM, Miaohe Lin wrote:
>> Convert the uses of fallthrough comments to fallthrough macro.
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>
>This is not a bug fix but rather an enhancement so not sure whether this should push to bpf tree or wait until bpf-next.
>
>It may be worthwhile to mention Commit 294f69e662d1
> ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") so people can understand why this patch is needed.
>

Will do. Many thanks.

>With above suggestions,
>Acked-by: Yonghong Song <yhs@...com>
>