netdev - Re: [PATCH net 1/2] cxgb4: Fix work request size calculation for loopback test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200818123345.00007802@intel.com>
Date:   Tue, 18 Aug 2020 12:33:45 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Ganji Aravind <ganji.aravind@...lsio.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <vishal@...lsio.com>, <rahul.lakkireddy@...lsio.com>
Subject: Re: [PATCH net 1/2] cxgb4: Fix work request size calculation for
 loopback test

Ganji Aravind wrote:

> Work request used for sending loopback packet needs to add
> the firmware work request only once. So, fix by using
> correct structure size.
> 
> Fixes: 7235ffae3d2c ("cxgb4: add loopback ethtool self-test")
> Signed-off-by: Ganji Aravind <ganji.aravind@...lsio.com>

changes look ok, but to understand why this change fixed the bug, you
could have just mentioned that the cpl_tx_pkt struct has a _core member
inside of it, and then I wouldn't have had to waste review time digging
through the code in the kernel.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>