netdev - Re: [PATCH v2 net-next] macvlan: validate setting of multiple remote source MAC addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200818.123433.794427906392998261.davem@davemloft.net>
Date:   Tue, 18 Aug 2020 12:34:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alsi@...g-olufsen.dk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] macvlan: validate setting of multiple
 remote source MAC addresses

From: Alvin Šipraga <alsi@...g-olufsen.dk>
Date: Tue, 18 Aug 2020 10:51:34 +0200

> Remote source MAC addresses can be set on a 'source mode' macvlan
> interface via the IFLA_MACVLAN_MACADDR_DATA attribute. This commit
> tightens the validation of these MAC addresses to match the validation
> already performed when setting or adding a single MAC address via the
> IFLA_MACVLAN_MACADDR attribute.
> 
> iproute2 uses IFLA_MACVLAN_MACADDR_DATA for its 'macvlan macaddr set'
> command, and IFLA_MACVLAN_MACADDR for its 'macvlan macaddr add' command,
> which demonstrates the inconsistent behaviour that this commit
> addresses:
> 
>  # ip link add link eth0 name macvlan0 type macvlan mode source
>  # ip link set link dev macvlan0 type macvlan macaddr add 01:00:00:00:00:00
>  RTNETLINK answers: Cannot assign requested address
>  # ip link set link dev macvlan0 type macvlan macaddr set 01:00:00:00:00:00
>  # ip -d link show macvlan0
>  5: macvlan0@...0: <BROADCAST,MULTICAST,DYNAMIC,UP,LOWER_UP> mtu 1500 ...
>      link/ether 2e:ac:fd:2d:69:f8 brd ff:ff:ff:ff:ff:ff promiscuity 0
>      macvlan mode source remotes (1) 01:00:00:00:00:00 numtxqueues 1 ...
> 
> With this change, the 'set' command will (rightly) fail in the same way
> as the 'add' command.
> 
> Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Applied, thank you.