netdev - Re: [PATCH bpf-next 4/4] tools: remove feature-libelf-mmap feature detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzYF8bor88TzOTY6rbmsWrnCkNBXHZBkvm6EzLJe4C+r_w@mail.gmail.com>
Date:   Tue, 18 Aug 2020 18:19:36 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 4/4] tools: remove feature-libelf-mmap feature detection

On Tue, Aug 18, 2020 at 6:08 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Aug 18, 2020 at 02:59:08PM -0700, Andrii Nakryiko wrote:
> > It's trivial to handle missing ELF_C_MMAP_READ support in libelf the way that
> > objtool has solved it in
> > ("774bec3fddcc objtool: Add fallback from ELF_C_READ_MMAP to ELF_C_READ").
> >
> > So instead of having an entire feature detector for that, just do what objtool
> > does for perf and libbpf. And keep their Makefiles a bit simpler.
> >
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> overall looks good, but this patch doesn't apply to bpf-next.

yeah, seems like patches you've already landed on bpf-next have
auto-resolvable conflicts. I'll rebase and post v2.