netdev - Re: [PATCH bpf-next 0/9] Add support for type-based and enum value-based CO-RE relocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200819012146.okpmhcqcffoe43sw@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 18 Aug 2020 18:21:46 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com,
        daniel@...earbox.net, andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH bpf-next 0/9] Add support for type-based and enum
 value-based CO-RE relocations

On Tue, Aug 18, 2020 at 03:39:12PM -0700, Andrii Nakryiko wrote:
> This patch set adds libbpf support to two new classes of CO-RE relocations:
> type-based (TYPE_EXISTS/TYPE_SIZE/TYPE_ID_LOCAL/TYPE_ID_TARGET) and enum
> value-vased (ENUMVAL_EXISTS/ENUMVAL_VALUE):
> 
> LLVM patches adding these relocation in Clang:
>   - __builtin_btf_type_id() ([0], [1], [2]);
>   - __builtin_preserve_type_info(), __builtin_preserve_enum_value() ([3], [4]).

I've applied patches 1-4, since they're somewhat indepedent of new features in 5+.
What should be the process to land the rest?
Land llvm first and add to bpf/README.rst that certain llvm commmits are necessary
to build the tests?
But CI will start failing. We can wait for that to be fixed,
but I wonder is there way to detect new clang __builtins automatically in
selftests and skip them if clang is too old?