netdev - Re: [PATCH NET] net: atlantic: Use readx_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200819.162548.1211800869018001410.davem@davemloft.net>
Date:   Wed, 19 Aug 2020 16:25:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bigeasy@...utronix.de
Cc:     irusskikh@...vell.com, netdev@...r.kernel.org,
        mstarovoitov@...vell.com, kuba@...nel.org, tglx@...utronix.de
Subject: Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large
 timeout

From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Date: Tue, 18 Aug 2020 18:14:39 +0200

> Commit
>    8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature")
> 
> implemented a read callback with an udelay(10000U). This fails to
> compile on ARM because the delay is >1ms. I doubt that it is needed to
> spin for 10ms even if possible on x86.
> 
> From looking at the code, the context appears to be preemptible so using
> usleep() should work and avoid busy spinning.
> 
> Use readx_poll_timeout() in the poll loop.
> 
> Cc: Mark Starovoytov <mstarovoitov@...vell.com>
> Cc: Igor Russkikh <irusskikh@...vell.com>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>

Applied, thanks.