lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Aug 2020 13:17:48 +0300 From: Igor Russkikh <irusskikh@...vell.com> To: Guenter Roeck <linux@...ck-us.net>, Sebastian Andrzej Siewior <bigeasy@...utronix.de> CC: <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>, "Thomas Gleixner" <tglx@...utronix.de>, Dmitry Bogdanov <dbogdanov@...vell.com> Subject: Re: [EXT] Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout >> implemented a read callback with an udelay(10000U). This fails to >> compile on ARM because the delay is >1ms. I doubt that it is needed to >> spin for 10ms even if possible on x86. >> >> >From looking at the code, the context appears to be preemptible so > using >> usleep() should work and avoid busy spinning. >> >> Use readx_poll_timeout() in the poll loop. >> >> Cc: Mark Starovoytov <mstarovoitov@...vell.com> >> Cc: Igor Russkikh <irusskikh@...vell.com> >> Signed-off-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc> > > Fixes: 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC > temperature") > Acked-by: Guenter Roeck <linux@...ck-us.net> > > As in: This patch does not cause any additional trouble and will fix the > observed compile failure. However, the submitter of 8dcf2ad39fdb2 might > consider adding a mutex either into hw_atl_b0_get_mac_temp() or into > the calling code. Hi Sebastian, Guenter, thanks for catching and taking care of this, Looks good for me so far. >> Could someone with hardware please verify it? It compiles, yes. >> We'll verify this on our side, sure. Regards, Igor
Powered by blists - more mailing lists