| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Aug 2020 18:52:09 -0700 (PDT) From: David Miller <davem@...emloft.net> To: xiangxia.m.yue@...il.com Cc: dev@...nvswitch.org, netdev@...r.kernel.org, pshelar@....org Subject: Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function From: Tonghao Zhang <xiangxia.m.yue@...il.com> Date: Thu, 20 Aug 2020 07:21:33 +0800 > On Thu, Aug 20, 2020 at 6:52 AM David Miller <davem@...emloft.net> wrote: > >> From: xiangxia.m.yue@...il.com >> >> Date: Tue, 18 Aug 2020 18:09:22 +0800 >> >> >> >> > Decrease table->count and ufid_count unconditionally, >> >> >> >> You don't explain why this is a valid transformation. >> >> >> >> Is it a bug fix? > > No > >> >> >> >> Can it never happen? >> >> >> >> What are the details and how did you determine this? > > I want to simplify the codes, when flushing the flow, previous codes don't > count the flow, because we have set them(flow counter/ufid counter)to 0. > Now don't set counter and count flow and ufid flow when deleting them, and > I add BUG_ON to make sure other patch no bug when flushing flow. Add these details to your commit message, please.
Powered by blists - more mailing lists