netdev - Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMDZJNV4RXtbzy8SyyLbUCt1LE2wCOBcTQYt=-WR5T_2hQMNCQ@mail.gmail.com>
Date:   Mon, 24 Aug 2020 15:39:41 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     ovs dev <dev@...nvswitch.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Pravin Shelar <pshelar@....org>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

On Thu, Aug 20, 2020 at 9:52 AM David Miller <davem@...emloft.net> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> Date: Thu, 20 Aug 2020 07:21:33 +0800
>
> > On Thu, Aug 20, 2020 at 6:52 AM David Miller <davem@...emloft.net> wrote:
> >
> >> From: xiangxia.m.yue@...il.com
> >>
> >> Date: Tue, 18 Aug 2020 18:09:22 +0800
> >>
> >>
> >>
> >> > Decrease table->count and ufid_count unconditionally,
> >>
> >>
> >>
> >> You don't explain why this is a valid transformation.
> >>
> >>
> >>
> >> Is it a bug fix?
> >
> > No
> >
> >>
> >>
> >>
> >> Can it never happen?
> >>
> >>
> >>
> >> What are the details and how did you determine this?
> >
> > I want to simplify the codes, when flushing the flow, previous codes don't
> > count the flow, because we have set them(flow counter/ufid counter)to 0.
> > Now don't set counter and count flow and ufid flow when deleting them, and
> > I add BUG_ON to make sure other patch no bug when flushing flow.
>
> Add these details to your commit message, please.
Hi David
v2 are sent, please review
http://patchwork.ozlabs.org/project/netdev/patch/20200824073602.70812-2-xiangxia.m.yue@gmail.com/
http://patchwork.ozlabs.org/project/netdev/patch/20200824073602.70812-3-xiangxia.m.yue@gmail.com/
http://patchwork.ozlabs.org/project/netdev/patch/20200824073602.70812-4-xiangxia.m.yue@gmail.com/

-- 
Best regards, Tonghao