lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2020 09:27:39 -0700 From: Jakub Kicinski <kuba@...nel.org> To: David Ahern <dsahern@...il.com> Cc: Ido Schimmel <idosch@...sch.org>, Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, davem@...emloft.net, jiri@...dia.com, amcohen@...dia.com, danieller@...dia.com, mlxsw@...dia.com, roopa@...dia.com, andrew@...n.ch, vivien.didelot@...il.com, tariqt@...dia.com, ayal@...dia.com, mkubecek@...e.cz, Ido Schimmel <idosch@...dia.com> Subject: Re: [RFC PATCH net-next 0/6] devlink: Add device metric support On Fri, 21 Aug 2020 19:18:37 -0600 David Ahern wrote: > On 8/21/20 6:37 PM, Jakub Kicinski wrote: > >>> # cat /proc/net/tls_stat > >> > >> I do not agree with adding files under /proc/net for this. > > > > Yeah it's not the best, with higher LoC a better solution should be > > within reach. > > The duplicity here is mind-boggling. Tls stats from hardware is on par > with Ido's *example* of vxlan stats from an ASIC. You agree that > /proc/net files are wrong, I didn't say /proc/net was wrong, I'm just trying to be agreeable. Maybe I need to improve my command of the English language. AFAIK /proc/net is where protocol stats are. > but you did it anyway and now you want the > next person to solve the problem you did not want to tackle but have > strong opinions on. I have no need and interest in vxlan stats. > Ido has a history of thinking through problems and solutions in a proper > Linux Way. netlink is the right API, and devlink was created for > 'device' stuff versus 'netdev' stuff. Hence, I agree with this > *framework* for extracting asic stats. You seem to focus on less relevant points. I primarily care about the statistics being defined and identified by Linux, not every vendor for themselves. No question about Ido's ability and contributions, but then again (from the cover letter): > This a joint work [...] during a two-day company hackathon.
Powered by blists - more mailing lists