lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2020 18:49:46 +0200 From: Andrew Lunn <andrew@...n.ch> To: Marek BehĂșn <marek.behun@....cz> Cc: netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com> Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add support for 88E6393X from Amethyst family > --- a/drivers/net/dsa/mv88e6xxx/port.c > +++ b/drivers/net/dsa/mv88e6xxx/port.c > @@ -187,11 +187,16 @@ static int mv88e6xxx_port_set_speed_duplex(struct mv88e6xxx_chip *chip, > ctrl = MV88E6XXX_PORT_MAC_CTL_SPEED_1000; > break; > case 2500: > - if (alt_bit) > - ctrl = MV88E6390_PORT_MAC_CTL_SPEED_10000 | > - MV88E6390_PORT_MAC_CTL_ALTSPEED; > + if (chip->info->family == MV88E6XXX_FAMILY_6393) > + ctrl = MV88E6XXX_PORT_MAC_CTL_SPEED_1000; > else > ctrl = MV88E6390_PORT_MAC_CTL_SPEED_10000; > + if (alt_bit) > + ctrl |= MV88E6390_PORT_MAC_CTL_ALTSPEED; > + break; > + case 5000: > + ctrl = MV88E6390_PORT_MAC_CTL_SPEED_10000 | > + MV88E6390_PORT_MAC_CTL_ALTSPEED; > break; > case 10000: > /* all bits set, fall through... */ This is getting more and more complex. Maybe it is time to refactor it? Andrew
Powered by blists - more mailing lists