lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2020 18:48:12 +0200 From: Andrew Lunn <andrew@...n.ch> To: Marek BehĂșn <marek.behun@....cz> Cc: netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com> Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add support for 88E6393X from Amethyst family > /* Set power up/down for 10GBASE-R and 10GBASE-X4/X2 */ > static int mv88e6390_serdes_power_10g(struct mv88e6xxx_chip *chip, u8 lane, > bool up) > @@ -678,8 +699,8 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, u8 lane, > case MV88E6XXX_PORT_STS_CMODE_2500BASEX: > err = mv88e6390_serdes_power_sgmii(chip, lane, up); > break; > - case MV88E6XXX_PORT_STS_CMODE_XAUI: > - case MV88E6XXX_PORT_STS_CMODE_RXAUI: > + case MV88E6XXX_PORT_STS_CMODE_XAUI: /* also MV88E6393_PORT_STS_CMODE_5GBASER */ > + case MV88E6XXX_PORT_STS_CMODE_RXAUI: /* also MV88E6393_PORT_STS_CMODE_10GBASER */ > err = mv88e6390_serdes_power_10g(chip, lane, up); > break; > } Not so nice. Maybe add a m88e6393_serdes_power() function to avoid this? Andrew
Powered by blists - more mailing lists