netdev - Re: [net-next v5 06/15] iecm: Implement mailbox functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200824134041.4249c0bd@kicinski-fedora-PC1C0HJN>
Date:   Mon, 24 Aug 2020 13:40:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Brady, Alan" <alan.brady@...el.com>
Cc:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Michael, Alice" <alice.michael@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "Burra, Phani R" <phani.r.burra@...el.com>,
        "Hay, Joshua A" <joshua.a.hay@...el.com>,
        "Chittim, Madhu" <madhu.chittim@...el.com>,
        "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>,
        "Skidmore, Donald C" <donald.c.skidmore@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Subject: Re: [net-next v5 06/15] iecm: Implement mailbox functionality

On Mon, 24 Aug 2020 20:35:51 +0000 Brady, Alan wrote:
> > @@ -28,7 +36,32 @@ static enum iecm_status iecm_ctlq_init_regs(struct
> > iecm_hw *hw,
> >  					    struct iecm_ctlq_info *cq,  
> 
> I believe we have made a grave error and sent the wrong version.
> iecm_status enum should be completely removed.  Sincere apologies for
> the thrash.  Will be sending another version up soon.

Ugh, I was half way through review.

Let me send my comments and you can see how many of them apply.