netdev - Re: [net-next v5 11/15] iecm: Add splitq TX/RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200824134054.4dd467bc@kicinski-fedora-PC1C0HJN>
Date:   Mon, 24 Aug 2020 13:40:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Alice Michael <alice.michael@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        jeffrey.t.kirsher@...el.com, Alan Brady <alan.brady@...el.com>,
        Phani Burra <phani.r.burra@...el.com>,
        Joshua Hay <joshua.a.hay@...el.com>,
        Madhu Chittim <madhu.chittim@...el.com>,
        Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
        Donald Skidmore <donald.c.skidmore@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [net-next v5 11/15] iecm: Add splitq TX/RX

On Mon, 24 Aug 2020 10:33:02 -0700 Tony Nguyen wrote:
>  void iecm_get_stats64(struct net_device *netdev,
>  		      struct rtnl_link_stats64 *stats)
>  {
> -	/* stub */
> +	struct iecm_vport *vport = iecm_netdev_to_vport(netdev);
> +
> +	iecm_send_get_stats_msg(vport);

Doesn't this call sleep? This .ndo callback can't sleep.