netdev - Re: [PATCH net] sfc: fix boolreturn.cocci warning and rename function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Aug 2020 18:14:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sfc: fix boolreturn.cocci warning and rename
 function

From: Edward Cree <ecree@...arflare.com>
Date: Mon, 24 Aug 2020 16:18:51 +0100

> check_fcs() was returning bool as 0/1, which was a sign that the sense
>  of the function was unclear: false was good, which doesn't really match
>  a name like 'check_$thing'.  So rename it to ef100_has_fcs_error(), and
>  use proper booleans in the return statements.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied, thank you.