netdev - Re: [PATCH bpf] bpf, sysctl: let bpf_stats_handler take a kernel pointer buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJ6g_ZYS-wQ-FN6p4X=MoVu65Qe_=-5O3eh-K_jB=kCCQ@mail.gmail.com>
Date:   Mon, 24 Aug 2020 21:14:47 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH bpf] bpf, sysctl: let bpf_stats_handler take a kernel
 pointer buffer

On Mon, Aug 24, 2020 at 7:20 AM Tobias Klauser <tklauser@...tanz.ch> wrote:
>
> Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
> changed ctl_table.proc_handler to take a kernel pointer. Adjust the
> signature of bpf_stats_handler to match ctl_table.proc_handler which
> fixes the following sparse warning:
>
> kernel/sysctl.c:226:49: warning: incorrect type in argument 3 (different address spaces)
> kernel/sysctl.c:226:49:    expected void *
> kernel/sysctl.c:226:49:    got void [noderef] __user *buffer
> kernel/sysctl.c:2640:35: warning: incorrect type in initializer (incompatible argument 3 (different address spaces))
> kernel/sysctl.c:2640:35:    expected int ( [usertype] *proc_handler )( ... )
> kernel/sysctl.c:2640:35:    got int ( * )( ... )
>
> Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
> Cc: Christoph Hellwig <hch@....de>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied. Thanks