netdev - Re: [PATCH bpf-next] selftests/bpf: enable tc verbose mode for test_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+jES5ho+wGWr3eLrGvnLC5AvNKYjmR-QvvyFmQj1ZJaw@mail.gmail.com>
Date:   Mon, 24 Aug 2020 21:18:07 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: enable tc verbose mode for test_sk_assign

On Mon, Aug 24, 2020 at 3:28 PM Yonghong Song <yhs@...com> wrote:
>
> Currently test_sk_assign failed verifier with llvm11/llvm12.
> During debugging, I found the default verifier output is
> truncated like below
>   Verifier analysis:
>
>   Skipped 2200 bytes, use 'verb' option for the full verbose log.
>   [...]
>   off=23,r=34,imm=0) R5=inv0 R6=ctx(id=0,off=0,imm=0) R7=pkt(id=0,off=0,r=34,imm=0) R10=fp0
>   80: (0f) r7 += r2
>   last_idx 80 first_idx 21
>   regs=4 stack=0 before 78: (16) if w3 == 0x11 goto pc+1
> when I am using "./test_progs -vv -t assign".
>
> The reason is tc verbose mode is not enabled.
>
> This patched enabled tc verbose mode and the output looks like below
>   Verifier analysis:
>
>   0: (bf) r6 = r1
>   1: (b4) w0 = 2
>   2: (61) r1 = *(u32 *)(r6 +80)
>   3: (61) r7 = *(u32 *)(r6 +76)
>   4: (bf) r2 = r7
>   5: (07) r2 += 14
>   6: (2d) if r2 > r1 goto pc+61
>    R0_w=inv2 R1_w=pkt_end(id=0,off=0,imm=0) R2_w=pkt(id=0,off=14,r=14,imm=0)
>   ...
>
> Signed-off-by: Yonghong Song <yhs@...com>

Applied. Thanks