netdev - RE: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1efebb42c30a4c40bf91649d83d60e1c@AcuMS.aculab.com>
Date:   Wed, 26 Aug 2020 15:06:51 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Lukasz Stelmach' <l.stelmach@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        "b.zolnierkie@...sung.com" <b.zolnierkie@...sung.com>
Subject: RE: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter
 Driver

From: Lukasz Stelmach
> Sent: 26 August 2020 15:59
> 
> It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote:
> >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
> >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
> >> supports SPI connection.
...
> >> +++ b/drivers/net/ethernet/asix/Kconfig
> >> @@ -0,0 +1,20 @@
> >> +#
> >> +# Asix network device configuration
> >> +#
> >> +
> >> +config NET_VENDOR_ASIX
> >> +	bool "Asix devices"
> >> +	depends on SPI
> >> +	help
> >> +	  If you have a network (Ethernet) interface based on a chip from ASIX, say Y
> >
> > Looks like too long, did it pass checkpatch?
> 
> Yes? Let me try again. Yes, this one passed, but I missed a few other
> problems. Thank you.
> 
> >> +
> >> +if NET_VENDOR_ASIX
> >> +
> >> +config SPI_AX88796C
> >> +	tristate "Asix AX88796C-SPI support"
> >> +	depends on SPI
> >> +	depends on GPIOLIB
> >> +	help
> >> +	  Say Y here if you intend to attach a Asix AX88796C as SPI mode
> >> +
> >> +endif # NET_VENDOR_ASIX

There are plenty of other ethernet devices made by ASIX (eg USB ones)
that have nothing at all to do with this driver.
So those questions are too broad.

The first one should probable be for ASIX SPI network devices.

(I can't imagine SPI being fast enough to be useful for ethernet...)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)