netdev - Re: [PATCH] bnx2x: correct a mistake when show error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfdMYCLNzWVKZMgmzU5oDg+6yhZ3JMaBv7_CmM7MCgY7A9iPQ@mail.gmail.com>
Date:   Sat, 29 Aug 2020 19:00:29 +0800
From:   Yi Li <yilikernel@...il.com>
To:     Yi Li <yili@...hong.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net,
        GR-everest-linux-l2@...vell.com, skalluru@...vell.com,
        aelior@...vell.com
Subject: Re: [PATCH] bnx2x: correct a mistake when show error code

It is useless.
The original code just tell some error info. and don't  show errorcode

On 8/29/20, Yi Li <yili@...hong.com> wrote:
> use rc for error code.
>
> Signed-off-by: Yi Li <yili@...hong.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> index 1426c691c7c4..0346771396ce 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x
> *bp, u32 shmem_base_path[],
>  	}
>
>  	if (rc)
> -		netdev_err(bp->dev,  "Warning: PHY was not initialized,"
> -				      " Port %d\n",
> -			 0);
> +		netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
> +			   rc);
>  	return rc;
>  }
>
> --
> 2.25.3
>
>
>
>