lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Aug 2020 10:58:01 +0300 From: Igor Russkikh <irusskikh@...vell.com> To: Yi Li <yili@...hong.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> CC: <yilikernel@...il.com>, <kuba@...nel.org>, <davem@...emloft.net>, GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>, "Sudarsana Reddy Kalluru" <skalluru@...vell.com>, Ariel Elior <aelior@...vell.com> Subject: Re: [EXT] [PATCH] bnx2x: correct a mistake when show error code > drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c > index 1426c691c7c4..0346771396ce 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c > @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x > *bp, u32 shmem_base_path[], > } > > if (rc) > - netdev_err(bp->dev, "Warning: PHY was not initialized," > - " Port %d\n", > - 0); > + netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n", > + rc); > return rc; Hi Yi, Thanks, but if you want to report rc in this trace - then state "rc = %d" explicitly in the string. Because now its "Port %d" but you put error code in there... Thanks, Igor
Powered by blists - more mailing lists