netdev - Re: [PATCH v3 bpf-next 2/5] bpf: Introduce sleepable BPF programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJ673LvCAgtZu3L+Lf36oVgKd330XboR3TdRHX1uYQtLQ@mail.gmail.com>
Date:   Mon, 31 Aug 2020 09:26:08 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Josef Bacik <josef@...icpanda.com>,
        Benjamin Poirier <bpoirier@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 2/5] bpf: Introduce sleepable BPF programs

On Mon, Aug 31, 2020 at 7:52 AM Björn Töpel <bjorn.topel@...il.com> wrote:
>
> On Fri, 28 Aug 2020 at 00:02, Alexei Starovoitov
> <alexei.starovoitov@...il.com> wrote:
> >
> > From: Alexei Starovoitov <ast@...nel.org>
> >
>
> [...]
>
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 6f5a9f51cc03..3ebfdb7bd427 100644
>
> [...]
>
> >
> > +/* non exhaustive list of sleepable bpf_lsm_*() functions */
> > +BTF_SET_START(btf_sleepable_lsm_hooks)
> > +#ifdef CONFIG_BPF_LSM
> > +BTF_ID(func, bpf_lsm_file_mprotect)
> > +BTF_ID(func, bpf_lsm_bprm_committed_creds)
> > +#endif
> > +BTF_SET_END(btf_sleepable_lsm_hooks)
> > +
>
> I'm getting:
>   FAILED unresolved symbol btf_sleepable_lsm_hooks
> when CONFIG_BPF_LSM is not set.
>
> Adding a BTF_UNUSED_ID unconditionally to the set helps, but I'm on a
> BTF limb here, so there might be a more correct/obvious workaround
> here...

yeah. thanks for reporting. The fix is on the way.