netdev - Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200831155151.0DCB5C4339C@smtp.codeaurora.org>
Date:   Mon, 31 Aug 2020 15:51:51 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Ganapathi Bhat <ganapathi.bhat@....com>,
        Xinming Hu <huxinming820@...il.com>
Subject: Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move
 'tos_to_tid_inv'
 to where it's used

Lee Jones <lee.jones@...aro.org> wrote:

> 'tos_to_tid_inv' is only used in 2 of 17 files it's current being
> included into.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  In file included from drivers/net/wireless/marvell/mwifiex/main.c:23:
>  In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26:
>  In file included from drivers/net/wireless/marvell/mwifiex/util.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/txrx.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/join.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_cmd.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_ioctl.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_event.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/uap_txrx.c:23:
>  In file included from drivers/net/wireless/marvell/mwifiex/sdio.c:27:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_tx.c:25:
>  drivers/net/wireless/marvell/mwifiex/wmm.h:41:17: warning: ‘tos_to_tid_inv’ defined but not used [-Wunused-const-variable=]
>  41 | static const u8 tos_to_tid_inv[] = {
> 
>  NB: Snipped for brevity
> 
> Cc: Amitkumar Karwar <amitkarwar@...il.com>
> Cc: Ganapathi Bhat <ganapathi.bhat@....com>
> Cc: Xinming Hu <huxinming820@...il.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

The patch creates two duplicate arrays, this makes it worse than it was
before.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/11723177/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches