netdev - Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200901163610.GD22807@hoboy>
Date:   Tue, 1 Sep 2020 09:36:10 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kamil Alkhouri <kamil.alkhouri@...offenburg.de>,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek
 switches

On Tue, Sep 01, 2020 at 05:59:45PM +0200, Andrew Lunn wrote:
> Maybe, at the moment, RTNL is keeping things atomic. But that is
> because there is no HWMON, or MDIO bus. Those sort of operations don't
> take the RTNL, and so would be an issue. I've also never audited the
> network stack to check RTNL really is held at all the network stack
> entry points to a DSA driver. It would be an interesting excesses to
> scatter some ASSERT_RTNL() in a DSA driver and see what happens.

Device drivers really aught to protect their state and their devices'
state from concurrent access.

Thanks,
Richard