netdev - Re: [PATCH v2 net 1/3] net: qed: Disable aRFS for NPAR and 100G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Sep 2020 18:29:19 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Dmitry Bogdanov <dbogdanov@...vell.com>, <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
CC:     Manish Chopra <manishc@...vell.com>,
        Michal Kalderon <mkalderon@...vell.com>
Subject: Re: [PATCH v2 net 1/3] net: qed: Disable aRFS for NPAR and 100G

Hi David,

Strangely I don't see this series from Dmitry on patchwork, but emails seems
reached the list correctly:

https://lore.kernel.org/netdev/20200831094326.0mIWCNw1jJrHOif9nW17zot9j5BvO_ZP0orBrhmv6KE@z/

Could you please help with that?

Thanks,
  Igor

On 31/08/2020 12:43 pm, Dmitry Bogdanov wrote:
> In CMT and NPAR the PF is unknown when the GFS block processes the
> packet. Therefore cannot use searcher as it has a per PF database,
> and thus ARFS must be disabled.
> 
> Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
> Signed-off-by: Manish Chopra <manishc@...vell.com>
> Signed-off-by: Igor Russkikh <irusskikh@...vell.com>
> Signed-off-by: Michal Kalderon <michal.kalderon@...vell.com>
> Signed-off-by: Dmitry Bogdanov <dbogdanov@...vell.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dev.c  | 11 ++++++++++-
>  drivers/net/ethernet/qlogic/qed/qed_l2.c   |  3 +++
>  drivers/net/ethernet/qlogic/qed/qed_main.c |  2 ++
>  include/linux/qed/qed_if.h                 |  1 +
>  4 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> index b3c9ebaf2280..c78a48ae9ea6 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> @@ -4253,7 +4253,8 @@ static int qed_hw_get_nvm_info(struct qed_hwfn
> *p_hwfn, struct qed_ptt *p_ptt)
>  			cdev->mf_bits = BIT(QED_MF_LLH_MAC_CLSS) |
>  					BIT(QED_MF_LLH_PROTO_CLSS) |
>  					BIT(QED_MF_LL2_NON_UNICAST) |
> -					BIT(QED_MF_INTER_PF_SWITCH);
> +					BIT(QED_MF_INTER_PF_SWITCH) |
> +					BIT(QED_MF_DISABLE_ARFS);
>  			break;
>  		case NVM_CFG1_GLOB_MF_MODE_DEFAULT:
>  			cdev->mf_bits = BIT(QED_MF_LLH_MAC_CLSS) |
> @@ -4266,6 +4267,14 @@ static int qed_hw_get_nvm_info(struct qed_hwfn
> *p_hwfn, struct qed_ptt *p_ptt)
>  
>  		DP_INFO(p_hwfn, "Multi function mode is 0x%lx\n",
>  			cdev->mf_bits);
> +
> +		/* In CMT the PF is unknown when the GFS block processes
> the
> +		 * packet. Therefore cannot use searcher as it has a per
> PF
> +		 * database, and thus ARFS must be disabled.
> +		 *
> +		 */
> +		if (QED_IS_CMT(cdev))
> +			cdev->mf_bits |= BIT(QED_MF_DISABLE_ARFS);
>  	}
>  
>  	DP_INFO(p_hwfn, "Multi function mode is 0x%lx\n",
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c
> b/drivers/net/ethernet/qlogic/qed/qed_l2.c
> index 4c6ac8862744..07824bf9d68d 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
> @@ -1980,6 +1980,9 @@ void qed_arfs_mode_configure(struct qed_hwfn
> *p_hwfn,
>  			     struct qed_ptt *p_ptt,
>  			     struct qed_arfs_config_params *p_cfg_params)
>  {
> +	if (test_bit(QED_MF_DISABLE_ARFS, &p_hwfn->cdev->mf_bits))
> +		return;
> +
>  	if (p_cfg_params->mode != QED_FILTER_CONFIG_MODE_DISABLE) {
>  		qed_gft_config(p_hwfn, p_ptt, p_hwfn->rel_pf_id,
>  			       p_cfg_params->tcp,
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c
> b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 2558cb680db3..309216ff7a84 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -444,6 +444,8 @@ int qed_fill_dev_info(struct qed_dev *cdev,
>  		dev_info->fw_eng = FW_ENGINEERING_VERSION;
>  		dev_info->b_inter_pf_switch =
> test_bit(QED_MF_INTER_PF_SWITCH,
>  						       &cdev->mf_bits);
> +		if (!test_bit(QED_MF_DISABLE_ARFS, &cdev->mf_bits))
> +			dev_info->b_arfs_capable = true;
>  		dev_info->tx_switching = true;
>  
>  		if (hw_info->b_wol_support == QED_WOL_SUPPORT_PME)
> diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
> index cd6a5c7e56eb..cdd73afc4c46 100644
> --- a/include/linux/qed/qed_if.h
> +++ b/include/linux/qed/qed_if.h
> @@ -623,6 +623,7 @@ struct qed_dev_info {
>  #define QED_MFW_VERSION_3_OFFSET	24
>  
>  	u32		flash_size;
> +	bool		b_arfs_capable;
>  	bool		b_inter_pf_switch;
>  	bool		tx_switching;
>  	bool		rdma_supported;
>