netdev - Re: [PATCH bpf-next v2 2/2] selftests/bpf: test task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Sep 2020 19:18:55 -0700
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: test task_file iterator
 without visiting pthreads



On 9/1/20 5:41 PM, Andrii Nakryiko wrote:
> On Thu, Aug 27, 2020 at 10:38 PM Yonghong Song <yhs@...com> wrote:
>>
>> Modified existing bpf_iter_test_file.c program to check whether
>> all accessed files from the main thread or not.
>>
>> Modified existing bpf_iter_test_file program to check
>> whether all accessed files from the main thread or not.
>>    $ ./test_progs -n 4
>>    ...
>>    #4/7 task_file:OK
>>    ...
>>    #4 bpf_iter:OK
>>    Summary: 1/24 PASSED, 0 SKIPPED, 0 FAILED
>>
>> Signed-off-by: Yonghong Song <yhs@...com>
>> ---
> 
> Acked-by: Andrii Nakryiko <andriin@...com>
> 
>>   .../selftests/bpf/prog_tests/bpf_iter.c       | 21 +++++++++++++++++++
>>   .../selftests/bpf/progs/bpf_iter_task_file.c  | 10 ++++++++-
>>   2 files changed, 30 insertions(+), 1 deletion(-)
>>
> 
> [...]
> 
>> +       if (CHECK(pthread_join(thread_id, &ret) || ret != NULL,
>> +                 "pthread_join", "pthread_join failed\n"))
>> +               goto done;
>> +
>> +       CHECK(skel->bss->count != 0, "",
> 
> nit: please use non-empty string for second argument

Okay, will change to "check_count" instead of empty string. Thanks!

> 
>> +             "invalid non pthread file visit %d\n", skel->bss->count);
>> +
>> +done:
>>          bpf_iter_task_file__destroy(skel);
>>   }
>>
> 
> [...]
>