netdev - Re: [PATCH bpf-next v2 2/2] selftests/bpf: test task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbQboQ3uPmXG2HAsv2=S3iJ5-6RQiC8Z8OymnCCyMJ77A@mail.gmail.com>
Date:   Tue, 1 Sep 2020 17:41:37 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: test task_file iterator
 without visiting pthreads

On Thu, Aug 27, 2020 at 10:38 PM Yonghong Song <yhs@...com> wrote:
>
> Modified existing bpf_iter_test_file.c program to check whether
> all accessed files from the main thread or not.
>
> Modified existing bpf_iter_test_file program to check
> whether all accessed files from the main thread or not.
>   $ ./test_progs -n 4
>   ...
>   #4/7 task_file:OK
>   ...
>   #4 bpf_iter:OK
>   Summary: 1/24 PASSED, 0 SKIPPED, 0 FAILED
>
> Signed-off-by: Yonghong Song <yhs@...com>
> ---

Acked-by: Andrii Nakryiko <andriin@...com>

>  .../selftests/bpf/prog_tests/bpf_iter.c       | 21 +++++++++++++++++++
>  .../selftests/bpf/progs/bpf_iter_task_file.c  | 10 ++++++++-
>  2 files changed, 30 insertions(+), 1 deletion(-)
>

[...]

> +       if (CHECK(pthread_join(thread_id, &ret) || ret != NULL,
> +                 "pthread_join", "pthread_join failed\n"))
> +               goto done;
> +
> +       CHECK(skel->bss->count != 0, "",

nit: please use non-empty string for second argument

> +             "invalid non pthread file visit %d\n", skel->bss->count);
> +
> +done:
>         bpf_iter_task_file__destroy(skel);
>  }
>

[...]