lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 3 Sep 2020 09:25:39 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
CC:     David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <linuxarm@...wei.com>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [RFC net-next] udp: add a GSO type for UDPv6



On 2020/9/2 22:33, Willem de Bruijn wrote:
> On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan <tanhuazhong@...wei.com> wrote:
>>
>> In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled
>> separately, for example, checksum offload, so add new GSO type
>> SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands
>> for UDPv4.
> 
> This is in preparation for hardware you have that actually cares about
> this distinction, I guess?
> 

it is mainly for separating checksum offload of IPv4 and IPv6 right now.
with this patch, the user can switch checksum offload of IPv4 and not
affect IPv6's, vice versa.

> 
>> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
>> index 2cc3cf8..b7c1a76 100644
>> --- a/include/linux/netdev_features.h
>> +++ b/include/linux/netdev_features.h
>> @@ -54,6 +54,7 @@ enum {
>>          NETIF_F_GSO_UDP_BIT,            /* ... UFO, deprecated except tuntap */
>>          NETIF_F_GSO_UDP_L4_BIT,         /* ... UDP payload GSO (not UFO) */
>>          NETIF_F_GSO_FRAGLIST_BIT,               /* ... Fraglist GSO */
>> +       NETIF_F_GSO_UDPV6_L4_BIT,       /* ... UDPv6 payload GSO (not UFO) */
>>          /**/NETIF_F_GSO_LAST =          /* last bit, see GSO_MASK */
>>                  NETIF_F_GSO_FRAGLIST_BIT,
> 
> Need to update NETIF_F_GSO_LAST then, too.

ok, thanks.

> 
> 

Powered by blists - more mailing lists