netdev - Re: [net-next PATCH 2/2 v2] net: dsa: rtl8366: Refactor VLAN/PVID init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ2JhxtY1KdAOPafdJF7ApEqJOjjBV98f29X7o_GY9WxQ@mail.gmail.com>
Date:   Sat, 5 Sep 2020 12:29:15 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH 2/2 v2] net: dsa: rtl8366: Refactor VLAN/PVID init

On Tue, Sep 1, 2020 at 9:14 PM Florian Fainelli <f.fainelli@...il.com> wrote:
> On 9/1/2020 12:08 PM, Linus Walleij wrote:

> [snip]
>
> > +     /* Update the MC entry */
> > +     vlanmc.member |= member;
> > +     vlanmc.untag |= untag;
> > +     vlanmc.fid = fid;
>
> Is not there a problem with rtl8366_vlan_del() which is clearing the
> entire vlanmc structure when it it should be doing:
>
>         vlanmc.member &= ~BIT(port);
>         vlanmc.untag &= ~BIT(port);
>
> or something along these lines?

You're right, I'll send a separate patch for this.

Yours,
Linus Walleij