netdev - RE: [PATCH net-next] net: xilinx: remove redundant null check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Sep 2020 13:14:05 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Michal Simek <michals@...inx.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] net: xilinx: remove redundant null check before
 clk_disable_unprepare()

> -----Original Message-----
> From: Zhang Changzhong <zhangchangzhong@...wei.com>
> Sent: Monday, September 7, 2020 6:32 PM
> To: Radhey Shyam Pandey <radheys@...inx.com>; davem@...emloft.net;
> kuba@...nel.org; Michal Simek <michals@...inx.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH net-next] net: xilinx: remove redundant null check before
> clk_disable_unprepare()
> 
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>

Thanks!
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index fa5dc299..9aafd3e 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -2038,8 +2038,7 @@ static int axienet_remove(struct platform_device
> *pdev)
> 
>  	axienet_mdio_teardown(lp);
> 
> -	if (lp->clk)
> -		clk_disable_unprepare(lp->clk);
> +	clk_disable_unprepare(lp->clk);
> 
>  	of_node_put(lp->phy_node);
>  	lp->phy_node = NULL;
> --
> 2.9.5