netdev - Re: [PATCH net-next] net: xilinx: remove redundant null check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200907133917.0dd18fc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 7 Sep 2020 13:39:17 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Radhey Shyam Pandey <radheys@...inx.com>
Cc:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Michal Simek <michals@...inx.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: xilinx: remove redundant null check
 before clk_disable_unprepare()

On Mon, 7 Sep 2020 13:14:05 +0000 Radhey Shyam Pandey wrote:
> > From: Zhang Changzhong <zhangchangzhong@...wei.com>
> > Sent: Monday, September 7, 2020 6:32 PM
> > To: Radhey Shyam Pandey <radheys@...inx.com>; davem@...emloft.net;
> > kuba@...nel.org; Michal Simek <michals@...inx.com>
> > Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> > Subject: [PATCH net-next] net: xilinx: remove redundant null check before
> > clk_disable_unprepare()
> > 
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, just
> > remove them.
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>  
> 
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>

Applied, thanks!