lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Sep 2020 02:54:51 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vladimir Oltean <olteanv@...il.com> Cc: davem@...emloft.net, f.fainelli@...il.com, vivien.didelot@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next] net: dsa: change PHY error message again On Tue, Sep 08, 2020 at 02:06:56AM +0300, Vladimir Oltean wrote: > slave_dev->name is only populated at this stage if it was specified > through a label in the device tree. However that is not mandatory. > When it isn't, the error message looks like this: > > [ 5.037057] fsl_enetc 0000:00:00.2 eth2: error -19 setting up slave PHY for eth%d > [ 5.044672] fsl_enetc 0000:00:00.2 eth2: error -19 setting up slave PHY for eth%d > [ 5.052275] fsl_enetc 0000:00:00.2 eth2: error -19 setting up slave PHY for eth%d > [ 5.059877] fsl_enetc 0000:00:00.2 eth2: error -19 setting up slave PHY for eth%d > > which is especially confusing since the error gets printed on behalf of > the DSA master (fsl_enetc in this case). > > Printing an error message that contains a valid reference to the DSA > port's name is difficult at this point in the initialization stage, so > at least we should print some info that is more reliable, even if less > user-friendly. That may be the driver name and the hardware port index. > > After this change, the error is printed as: > > [ 6.051587] mscc_felix 0000:00:00.5: error -19 setting up PHY for tree 0, switch 0, port 0 > [ 6.061192] mscc_felix 0000:00:00.5: error -19 setting up PHY for tree 0, switch 0, port 1 > [ 6.070765] mscc_felix 0000:00:00.5: error -19 setting up PHY for tree 0, switch 0, port 2 > [ 6.080324] mscc_felix 0000:00:00.5: error -19 setting up PHY for tree 0, switch 0, port 3 > > Signed-off-by: Vladimir Oltean <olteanv@...il.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists