netdev - Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200908005709.GB3267902@lunn.ch>
Date:   Tue, 8 Sep 2020 02:57:09 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     kuba@...nel.org, f.fainelli@...il.com, vivien.didelot@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if
 not supported

On Tue, Sep 08, 2020 at 02:25:56AM +0300, Vladimir Oltean wrote:
> Commit 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set
> the MTU") changed, for some reason, the "err && err != -EOPNOTSUPP"
> check into a simple "err". This causes the MTU warning to be printed
> even for drivers that don't have the MTU operations implemented.
> Fix that.

Hi Vladimir

In some ways, this has been good. A lot more DSA drivers now have MTU
support and jumbo packet support.

> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew