netdev - Re: [PATCH net] tg3: Fix soft lockup when tg3_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <726c3fa7-9090-d8d1-d9f0-97e9f4445033@linux.vnet.ibm.com>
Date:   Tue, 8 Sep 2020 09:55:46 -0700
From:   David Christensen <drc@...ux.vnet.ibm.com>
To:     Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, kuba@...nel.org, baptiste@...sta.com
Subject: Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

On 9/3/20 11:28 AM, Michael Chan wrote:
> If tg3_reset_task() fails, the device state is left in an inconsistent
> state with IFF_RUNNING still set but NAPI state not enabled.  A
> subsequent operation, such as ifdown or AER error can cause it to
> soft lock up when it tries to disable NAPI state.
> 
> Fix it by bringing down the device to !IFF_RUNNING state when
> tg3_reset_task() fails.  tg3_reset_task() running from workqueue
> will now call tg3_close() when the reset fails.  We need to
> modify tg3_reset_task_cancel() slightly to avoid tg3_close()
> calling cancel_work_sync() to cancel tg3_reset_task().  Otherwise
> cancel_work_sync() will wait forever for tg3_reset_task() to
> finish.
> 
> Reported-by: David Christensen <drc@...ux.vnet.ibm.com>
> Reported-by: Baptiste Covolato <baptiste@...sta.com>
> Fixes: db2199737990 ("tg3: Schedule at most one tg3_reset_task run")
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Thanks for the patch, I'll have some test time scheduled and let you know.

Dave