netdev - Re: [PATCH net] tg3: Fix soft lockup when tg3_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb8VeFjyiMrgN++VxjDu_dYZL7ZeJCAKfgaSKJGWF5x7c-BOg@mail.gmail.com>
Date:   Thu, 10 Sep 2020 16:00:10 -0700
From:   Baptiste Covolato <baptiste@...sta.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        David Christensen <drc@...ux.vnet.ibm.com>
Subject: Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

Hi Michael,

On Sat, Sep 5, 2020 at 2:02 AM Michael Chan <michael.chan@...adcom.com> wrote:
> Now we have AER errors detected on 2 other tg3 devices, not from the
> one above with tg3_abort_hw() failure.
>
> I think this issue that you're reporting is not the same as David's
> issue of TX timeout happening at about the same time as AER.
>
> Please describe the issue in more detail, in particular how's the
> tg3_abort_hw() seen above initiated and how many tg3 devices do you
> have.  Also, are you injecting these AER errors?  Please also include
> the complete dmesg.  Thanks.

Sorry for the delay in response. I have been running some more
experiments with this issue to try to gather as much information as
possible. While running those experiments I noticed some strange
behavior on my system with PCI. I finally narrowed down the issue to
an improper power on sequence. After I fixed this, all my issues with
the tg3 are gone (tested with this patch applied). I think we're all
good now.

I'll let you know if I see any issues in the future.

Thanks