netdev - Re: [net-next 09/10] net/mlx5e: Move TX code into functions to be used by MPWQE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTScVsah+=DeQ3EYnK92fr_S9F+gvn0F2hJ5_cMtx1L3fjA@mail.gmail.com>
Date:   Tue, 8 Sep 2020 11:04:22 +0200
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Maxim Mikityanskiy <maximmi@...dia.com>
Cc:     Saeed Mahameed <saeedm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        Maxim Mikityanskiy <maximmi@...lanox.com>
Subject: Re: [net-next 09/10] net/mlx5e: Move TX code into functions to be
 used by MPWQE

On Tue, Sep 8, 2020 at 11:00 AM Maxim Mikityanskiy <maximmi@...dia.com> wrote:
>
> On 2020-09-04 18:06, Willem de Bruijn wrote:
> > On Thu, Sep 3, 2020 at 11:01 PM Saeed Mahameed <saeedm@...dia.com> wrote:
> >>
> >> From: Maxim Mikityanskiy <maximmi@...lanox.com>
> >>
> >> mlx5e_txwqe_complete performs some actions that can be taken to separate
> >> functions:
> >>
> >> 1. Update the flags needed for hardware timestamping.
> >>
> >> 2. Stop the TX queue if it's full.
> >>
> >> Take these actions into separate functions to be reused by the MPWQE
> >> code in the following commit and to maintain clear responsibilities of
> >> functions.
> >>
> >> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>
> >> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> >> ---
> >>   .../net/ethernet/mellanox/mlx5/core/en_tx.c   | 23 ++++++++++++++-----
> >>   1 file changed, 17 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
> >> index 9ced350150b3..3b68c8333875 100644
> >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
> >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
> >> @@ -311,6 +311,20 @@ static inline void mlx5e_sq_calc_wqe_attr(struct sk_buff *skb,
> >>          };
> >>   }
> >>
> >> +static inline void mlx5e_tx_skb_update_hwts_flags(struct sk_buff *skb)
> >> +{
> >> +       if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP))
> >> +               skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
> >> +}
> >
> > Subjective, but this helper adds a level of indirection and introduces
> > code churn without simplying anything, imho.
>
> It's added for the sake of being reused in non-MPWQE and MPWQE flows.

I understand. I'm just saying that a helper for two lines whose
function is clear just adds a layer of obfuscation. As said, that is
subjective, so just keep as is as you disagree.