lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 9 Sep 2020 18:34:08 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Wang Qing <wangqing@...o.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/netfilter: fix a typo for nf_conntrack_proto_dccp.c

Hi Wang,

On Wed, Sep 09, 2020 at 08:12:44PM +0800, Wang Qing wrote:
> Change the comment typo: "direcly" -> "directly".
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>

git log  tells me that the correct prefix for this patch
is "netfilter: conntrack:"  rather than "net/netfilter:"

Probably this patch is targeted at nf-next and should include nf-next
in the subject like this: [PATCH nf-next] ...

> ---
>  net/netfilter/nf_conntrack_proto_dccp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_conntrack_proto_dccp.c b/net/netfilter/nf_conntrack_proto_dccp.c
> index b3f4a33..d9bb0ce
> --- a/net/netfilter/nf_conntrack_proto_dccp.c
> +++ b/net/netfilter/nf_conntrack_proto_dccp.c
> @@ -340,7 +340,7 @@ dccp_state_table[CT_DCCP_ROLE_MAX + 1][DCCP_PKT_SYNCACK + 1][CT_DCCP_MAX + 1] =
>  		 * sNO -> sIV		No connection
>  		 * sRQ -> sIV		No connection
>  		 * sRS -> sIV		No connection
> -		 * sPO -> sOP -> sCG	Move direcly to CLOSING
> +		 * sPO -> sOP -> sCG	Move directly to CLOSING
>  		 * sOP -> sCG		Move to CLOSING
>  		 * sCR -> sIV		Close after CloseReq is invalid
>  		 * sCG -> sCG		Retransmit
> -- 
> 2.7.4
> 

Powered by blists - more mailing lists