netdev - Re: [Intel-wired-lan] [PATCH net-next] i40e: remove redundant assigment

Open Source and information security mailing list archives

Date:   Wed, 9 Sep 2020 15:56:07 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Marek Majtyka <alardam@...il.com>
Cc:     "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Netdev <netdev@...r.kernel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Marek Majtyka <marekx.majtyka@...el.com>,
        maciejromanfijalkowski@...in.com
Subject: Re: [Intel-wired-lan] [PATCH net-next] i40e: remove redundant assigment

On Tue, 8 Sep 2020 at 15:53, Marek Majtyka <alardam@...il.com> wrote:
>
> Remove a redundant assigment of the software ring pointer in the i40e
> driver. The variable is assigned twice with no use in between, so just
> get rid of the first occurrence.
>
> Fixes: 3b4f0b66c2b3 ("i40e, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL")
> Signed-off-by: Marek Majtyka <marekx.majtyka@...el.com>

Nice!

Acked-by: Björn Töpel <bjorn.topel@...el.com>

Hmm, this could actually go to the net tree.

Björn

> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 2a1153d8957b..8661f461f620 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -306,7 +306,6 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
>                         continue;
>                 }
>
> -               bi = i40e_rx_bi(rx_ring, rx_ring->next_to_clean);
>                 size = (qword & I40E_RXD_QW1_LENGTH_PBUF_MASK) >>
>                        I40E_RXD_QW1_LENGTH_PBUF_SHIFT;
>                 if (!size)
> --
> 2.20.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives