lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 08 Sep 2020 19:28:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     grygorii.strashko@...com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, vigneshr@...com,
        m-karicheri2@...com, nsekhar@...com, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static
 configuration

From: Grygorii Strashko <grygorii.strashko@...com>
Date: Mon, 7 Sep 2020 17:31:36 +0300

> +	ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id);
> +	if (ale_dev_id) {
> +		params->ale_entries = ale_dev_id->tbl_entries;
> +		params->major_ver_mask = ale_dev_id->major_ver_mask;
...
> -	if (!ale->params.major_ver_mask)
> -		ale->params.major_ver_mask = 0xff;

This is exactly the kind of change that causes regressions.

The default for the mask if no dev_id is found is now zero, whereas
before the default mask would be 0xff.

Please don't make changes like this, they are very risky.

In every step of these changes, existing behavior should be maintained
as precisely as possible.  Be as conservative as possible.

Powered by blists - more mailing lists