netdev - Re: [PATCH] net: sched: skip an unnecessay check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 08 Sep 2020 19:34:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     trix@...hat.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sched: skip an unnecessay check

From: trix@...hat.com
Date: Mon,  7 Sep 2020 11:04:38 -0700

> From: Tom Rix <trix@...hat.com>
> 
> Reviewing the error handling in tcf_action_init_1()
> most of the early handling uses
> 
> err_out:
> 	if (cookie) {
> 		kfree(cookie->data);
> 		kfree(cookie);
> 	}
> 
> before cookie could ever be set.
> 
> So skip the unnecessay check.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied to net-next, thank you.