[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200910073816.5b089bde@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Thu, 10 Sep 2020 07:38:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: David Miller <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>, Chris Healy <cphealy@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Jiri Pirko <jiri@...dia.com>,
Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH v3 net-next 2/9] net: devlink: region: Pass the region
ops to the snapshot function
On Thu, 10 Sep 2020 01:58:20 +0200 Andrew Lunn wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c
> index 111d6bfe4222..eb189d2070ae 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devlink.c
> +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c
> @@ -413,6 +413,7 @@ void ice_devlink_destroy_port(struct ice_pf *pf)
> * error code on failure.
> */
> static int ice_devlink_nvm_snapshot(struct devlink *devlink,
> + const struct devlink_region_ops *ops,
> struct netlink_ext_ack *extack, u8 **data)
> {
> struct ice_pf *pf = devlink_priv(devlink);
> @@ -468,6 +469,7 @@ static int ice_devlink_nvm_snapshot(struct devlink *devlink,
> */
> static int
> ice_devlink_devcaps_snapshot(struct devlink *devlink,
> + const struct devlink_region_ops *ops,
> struct netlink_ext_ack *extack, u8 **data)
> {
> struct ice_pf *pf = devlink_priv(devlink);
drivers/net/ethernet/intel/ice/ice_devlink.c:418: warning: Function parameter or member 'ops' not described in 'ice_devlink_nvm_snapshot'
drivers/net/ethernet/intel/ice/ice_devlink.c:474: warning: Function parameter or member 'ops' not described in 'ice_devlink_devcaps_snapshot'
Powered by blists - more mailing lists