netdev - Re: [PATCH 2/5] dpaa2-eth: define a global ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200910074047.046583a3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Sep 2020 07:40:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yangbo Lu <yangbo.lu@....com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Ioana Radulescu <ruxandra.radulescu@....com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH 2/5] dpaa2-eth: define a global ptp_qoriq structure
 pointer

On Thu, 10 Sep 2020 17:38:32 +0800 Yangbo Lu wrote:
> Define a global ptp_qoriq structure pointer, and export to use.
> The ptp clock operations will be used in dpaa2-eth driver.
> For example, supporting one step timestamping needs to write
> current time to hardware frame annotation before sending and
> then hardware inserts the delay time on frame during sending.
> So in driver, at least clock gettime operation will be needed
> to make sure right time is written to hardware frame annotation
> for one step timestamping.

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:34:18: warning: symbol 'dpaa2_ptp' was not declared. Should it be static?