lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 10 Sep 2020 14:02:36 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [net-next v4 4/5] devlink: add support for overwrite mask to
 netdevsim



On 9/9/2020 6:05 PM, Jakub Kicinski wrote:
> On Wed,  9 Sep 2020 15:26:52 -0700 Jacob Keller wrote:
>> The devlink interface recently gained support for a new "overwrite mask"
>> parameter that allows specifying how various sub-sections of a flash
>> component are modified when updating.
>>
>> Add support for this to netdevsim, to enable easily testing the
>> interface. Make the allowed overwrite mask values controllable via
>> a debugfs parameter. This enables testing a flow where the driver
>> rejects an unsupportable overwrite mask.
>>
>> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> nit: subject should be prefixed with netdevsim: not devlink:
> 
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> 

Yep. when I split the patch apart, I had copied and edited the commit
message but forgot to change the subject.

Powered by blists - more mailing lists