netdev - Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200912.182219.1013721666435098048.davem@davemloft.net>
Date:   Sat, 12 Sep 2020 18:22:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     luojiaxing@...wei.com
Cc:     kuba@...nel.org, idos@...lanox.com, ogerlitz@...lanox.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value
 to ring_cons but not used it anymore in mlx4_en_xmit()

From: Luo Jiaxing <luojiaxing@...wei.com>
Date: Sat, 12 Sep 2020 16:08:15 +0800

> We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will
> cause a warning when build the kernel. And after checking the commit record
> of this function, we found that it was introduced by a previous patch.
> 
> So, We delete this redundant assignment code.
> 
> Fixes: 488a9b48e398 ("net/mlx4_en: Wake TX queues only when there's enough room")
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>

Looks good, applied, thanks.